ourdigital/our-claude-skills
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(notion-writer): fail loudly on markdown image append + upsert prop update

Browse Source 
Mirror the blocks path's error handling in the markdown engine:
- page + DB markdown two-phase image append now check append_to_page's
  return and exit(1) on failure instead of printing success silently
- markdown DB upsert guards update_page_properties return
- restore blocks-engine page progress print + replace-failure print
- move unused parent computation into the create branch

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Andrew Yim
2026-06-27 10:08:20 +09:00
parent b14701d92c
commit 5e898f81e7
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
custom-skills/32-notion-writer/code/scripts/notion_writer.py
View File

@@ -976,8 +976,9 @@ Examples:
except APIResponseError as exc: except APIResponseError as exc:
print(f"Error: {compat.explain_api_error(exc, formatted_id)}") print(f"Error: {compat.explain_api_error(exc, formatted_id)}")
sys.exit(1) sys.exit(1)
if local_imgs: if local_imgs and not append_to_page(notion, page_id, _upload_blocks_for(local_imgs)):
append_to_page(notion, page_id, _upload_blocks_for(local_imgs)) print("❌ Text was written but image append failed")
sys.exit(1)
print("✅ Successfully wrote content to page (markdown engine)") print("✅ Successfully wrote content to page (markdown engine)")
print(f" https://notion.so/{formatted_id.replace('-', '')}") print(f" https://notion.so/{formatted_id.replace('-', '')}")
return return
@@ -990,7 +991,9 @@ Examples:
if not blocks: if not blocks:
print("No content to write") print("No content to write")
sys.exit(1) sys.exit(1)
print(f"{'Replacing' if args.replace else 'Appending'} content to page...")
if args.replace and not clear_page_content(notion, page_id): if args.replace and not clear_page_content(notion, page_id):
print("❌ Failed to write content")
sys.exit(1) sys.exit(1)
if append_to_page(notion, page_id, blocks): if append_to_page(notion, page_id, blocks):
print("✅ Successfully wrote content to page") print("✅ Successfully wrote content to page")
@@ -1080,22 +1083,24 @@ Examples:
ntn_files.preflight() ntn_files.preflight()
md_body, local_imgs = extract_local_images(md_content) md_body, local_imgs = extract_local_images(md_content)
md_body = md_translate.translate(md_body) md_body = md_translate.translate(md_body)
parent = compat.build_data_source_parent(data_source_id)
mc = _md_client() mc = _md_client()
try: try:
if args.upsert_by and existing: if args.upsert_by and existing:
compat.replace_markdown(mc, existing['id'], md_body, compat.replace_markdown(mc, existing['id'], md_body,
allow_deleting=args.allow_deleting) allow_deleting=args.allow_deleting)
update_page_properties(notion, existing['id'], properties) if not update_page_properties(notion, existing['id'], properties):
sys.exit(1)
new_id = existing['id'] new_id = existing['id']
else: else:
parent = compat.build_data_source_parent(data_source_id)
result = compat.create_page_markdown(mc, parent, properties, md_body) result = compat.create_page_markdown(mc, parent, properties, md_body)
new_id = result['id'] new_id = result['id']
except APIResponseError as exc: except APIResponseError as exc:
print(f"Error: {compat.explain_api_error(exc)}") print(f"Error: {compat.explain_api_error(exc)}")
sys.exit(1) sys.exit(1)
if local_imgs: if local_imgs and not append_to_page(notion, new_id, _upload_blocks_for(local_imgs)):
append_to_page(notion, new_id, _upload_blocks_for(local_imgs)) print("❌ Text was written but image append failed")
sys.exit(1)
print("✅ Successfully wrote database row (markdown engine)") print("✅ Successfully wrote database row (markdown engine)")
print(f" https://notion.so/{new_id.replace('-', '')}") print(f" https://notion.so/{new_id.replace('-', '')}")
return return